Merged
Conversation
NullVoxPopuli
commented
Feb 8, 2026
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-03-03 19:32:00.000000000 +0000
+++ pr/./pr-22639312792/out.txt 2026-03-03 19:33:26.000000000 +0000
@@ -1,36 +1,36 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 352.17 KB │ 203.84 KB ║
+║ Total │ 351.89 KB │ 203.81 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.39 KB │ 181.81 KB ║
+║ Total │ 313.12 KB │ 181.72 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 36.65 KB │ 26.25 KB ║
-║ application │ 13.23 KB │ 8 KB ║
-║ array │ 13.01 KB │ 7.62 KB ║
+║ -internals │ 36.58 KB │ 26.2 KB ║
+║ application │ 13.23 KB │ 8.02 KB ║
+║ array │ 13.01 KB │ 7.57 KB ║
║ canary-features │ 304 B │ 389 B ║
-║ component │ 2.05 KB │ 1.6 KB ║
-║ controller │ 1.96 KB │ 1.44 KB ║
-║ debug │ 11.69 KB │ 8.12 KB ║
+║ component │ 2.05 KB │ 1.59 KB ║
+║ controller │ 1.9 KB │ 1.39 KB ║
+║ debug │ 11.69 KB │ 8.09 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 1.08 KB │ 824 B ║
+║ helper │ 1.08 KB │ 813 B ║
║ instrumentation │ 2.43 KB │ 1.79 KB ║
-║ modifier │ 1.22 KB │ 981 B ║
-║ object │ 35.94 KB │ 21.88 KB ║
+║ modifier │ 1.22 KB │ 967 B ║
+║ object │ 35.8 KB │ 21.93 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 630 B │ 517 B ║
+║ renderer │ 630 B │ 493 B ║
║ routing │ 59.3 KB │ 34.13 KB ║
-║ runloop │ 2.36 KB │ 1.45 KB ║
-║ service │ 1 KB │ 845 B ║
-║ template │ 654 B │ 532 B ║
+║ runloop │ 2.36 KB │ 1.48 KB ║
+║ service │ 1 KB │ 863 B ║
+║ template │ 654 B │ 546 B ║
║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 123.08 KB │ 59.45 KB ║
+║ template-compiler │ 123.08 KB │ 59.47 KB ║
║ template-factory │ 370 B │ 374 B ║
║ test │ 923 B │ 627 B ║
║ utils │ 4.11 KB │ 3.63 KB ║
@@ -40,7 +40,7 @@
╔═════════════════╤══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼──────────┼──────────╢
-║ Total │ 38.78 KB │ 22.03 KB ║
+║ Total │ 38.78 KB │ 22.09 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable │ 2.95 KB │ 1.52 KB ║
║ encoder │ 81 B │ 171 B ║
@@ -53,7 +53,7 @@
║ program │ 252 B │ 295 B ║
║ reference │ 548 B │ 509 B ║
║ runtime │ 10.32 KB │ 5.21 KB ║
-║ tracking │ 1.34 KB │ 1.18 KB ║
+║ tracking │ 1.34 KB │ 1.25 KB ║
║ util │ 1.94 KB │ 1.68 KB ║
║ validator │ 15.75 KB │ 7.05 KB ║
║ vm │ 495 B │ 569 B ║Details
|
NullVoxPopuli
changed the title
NullVoxPopuli
commented
Feb 8, 2026
driesdl
approved these changes
Feb 9, 2026
ef4
reviewed
Feb 20, 2026
NullVoxPopuli
force-pushed
the
nvp/remove-some-ie11-support
branch
from
e668628 to
e00d6b4
Compare
Contributor
Author
|
@copilot pull in the missing changes from this https://github.com/NullVoxPopuli/ember.js/pull/11/changes around the curly component manager (and consumers of that new exported function) |
Contributor
|
@NullVoxPopuli I've opened a new pull request, #21112, to work on those changes. Once the pull request is ready, I'll request review from you. |
NullVoxPopuli
force-pushed
the
nvp/remove-some-ie11-support
branch
2 times, most recently
from
d37462d to
65fd5bb
Compare
Remove references to symbol Remove reference to isInternalSymbol Make sure ARGS and HAS_BLOCK are still acceessible (without big changes) Fix unused hasBlock parameter and TypeScript error Co-authored-by: NullVoxPopuli <[email protected]> Remove unused _hasBlock parameter from create() signature Co-authored-by: NullVoxPopuli <[email protected]> Cleanup Restore package.json Initial plan Use WeakMap for capturedArgs instead of symbol-keyed property on component Co-authored-by: NullVoxPopuli <[email protected]> Remove unused ARGS and HAS_BLOCK symbol exports from curly component manager Co-authored-by: NullVoxPopuli <[email protected]> Clean up comments in curly.ts Removed comments about WeakMap usage for capturedArgs.
NullVoxPopuli
force-pushed
the
nvp/remove-some-ie11-support
branch
from
e0d6b5e to
ab00acc
Compare
Contributor
📊 Package size report -0.06%↓
🤖 This report was automatically generated by pkg-size-action |
ef4
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dropped IE11 long ago, and forgot to clean this up
bench results are unchanged
artifact-2.pdf